Update comparator for Synchronized Sequence to be safer with distributed systems #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 9, 2019 14:35
…ted systems Provides some level of security over duplicated commits when comparing shadows Without this additional criteria, shadows with the same commit id will get the commit metadata from the earliest commit, rather than the commit associated to the shadow object
… the other generators
|
thanks @duro1 |
|
btw, your commits are not linked to your github account, if you link them, you will be automatically counted as javers contributor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides some level of security over duplicated commits when comparing shadows
Without this additional criteria, shadows with the same commit id will get the commit metadata from the earliest commit, rather than the commit associated to the shadow object
#894