Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error on dependency scanning - dependencyInfo.name might be null #65

Closed
skurfuerst opened this issue Dec 11, 2020 · 2 comments · Fixed by #70
Closed

Fatal error on dependency scanning - dependencyInfo.name might be null #65

skurfuerst opened this issue Dec 11, 2020 · 2 comments · Fixed by #70
Assignees
Labels
bug Something isn't working
Milestone

Comments

@skurfuerst
Copy link
Contributor

Hey,

thanks for this great library 👍 I was looking for a JS/TS library to do Architecture Tests (like https://www.archunit.org/, but inJS), and IMHO your library is extremely close to that!

I ran it with a medium-sized codebase; and possibly found an error:

In my case, the system broke with the following error:

TypeError: Cannot read property 'split' of undefined
Occurred while linting /Users/sebastian/src/kiwigrid/solarwatt-smart-setup/src/Redux/Sagas/BatteryRebootProcess.ts:2
    at ImportDeclaration (/Users/sebastian/src/kiwigrid/solarwatt-smart-setup/node_modules/eslint-plugin-boundaries/src/rules/no-external.js:62:57)
    at /Users/sebastian/src/kiwigrid/solarwatt-smart-setup/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/sebastian/src/kiwigrid/solarwatt-smart-setup/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/Users/sebastian/src/kiwigrid/solarwatt-smart-setup/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (/Users/sebastian/src/kiwigrid/solarwatt-smart-setup/node_modules/eslint/lib/linter/node-event-generator.js:283:22)
    at NodeEventGenerator.enterNode (/Users/sebastian/src/kiwigrid/solarwatt-smart-setup/node_modules/eslint/lib/linter/node-event-generator.js:297:14)
    at CodePathAnalyzer.enterNode (/Users/sebastian/src/kiwigrid/solarwatt-smart-setup/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:634:23)
    at /Users/sebastian/src/kiwigrid/solarwatt-smart-setup/node_modules/eslint/lib/linter/linter.js:936:32
    at Array.forEach (<anonymous>)

... while parsing the line:

import { RootState } from '../index';

See the related Pull Request for a possible fix :-)

All the best, and keep up the good work,
Sebastian

@javierbrea
Copy link
Owner

Hi @skurfuerst , I'm glad you like the plugin, thank you very much for your bug report! 🙂
Please feel free to open the PR from your repository to the release branch of this one by yourself, and I will add some tests afterwards.

@skurfuerst
Copy link
Contributor Author

@javierbrea Hey :) I thought I did, but I selected the wrong repo 🤦

#66 Here we go 👍

All the best,
Sebastian

javierbrea added a commit that referenced this issue Dec 11, 2020
javierbrea added a commit that referenced this issue Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants