Clarify approve_all flag location #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* release/3.3.0: preparing release 3.3.0 Bump version: 3.2.3 → 3.3.0 Fixed version number. Update versions list Update python-package.yml to my own coveralls version All documentation updated. README and usage documentation updated. fix github actions yaml All tests fixed. Black style applied. Removed support for Python 3.11 (aiohttp needs to be upgraded). Tests migrated to new version. Now SPADE supports Python>=3.8. WiP: One test failing changed the way agents are run, now with spade.run. quit_spade is deprecated. Examples updated. Need to update tests. fixing tests. Removed Aiothread. updating dependencies for backwards compatibility. WiP Removed loop on create Event because deprecation Added decorator for async tests Removed deprecated loop argumento from asyncio.Queue Removed deprecated asynctest. Replaced with unittest Changed test_client to aiohttp_client in pytest-aiohttp new version Updated dependencies
Specify what class the `approve_all` flag belongs to. For me personally, it was not directly clear what class the flag belonged to and I had to inspect the source code. I propose this change to make this more clear in the docs.
Pull Request Test Coverage Report for Build 5749708730
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify what class the
approve_allflag belongs to.For me personally, it was not directly clear what class the flag belonged to and I had to inspect the source code. I propose this change to make this more clear in the docs.