Code improvement #82
Open
Code improvement #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed class Main to match naming conventions
javatlacati
requested changes
Apr 9, 2021
| @@ -60,7 +59,7 @@ public Config() { | |||
|
|
|||
| public boolean loadDefaultSettings() { | |||
| //obtiene el archivo default.properties | |||
| InputStream defaultFile = Main.class.getClassLoader().getResourceAsStream("default.properties"); | |||
| InputStream defaultFile = GameRunner.class.getClassLoader().getResourceAsStream("default.properties"); | |||
There was a problem hiding this comment.
No se cierran los flujos en caso de error lo que peude corromper los archivos de configuración.
| @@ -262,7 +262,8 @@ public int opciones() { | |||
| return opc; | |||
| } | |||
|
|
|||
| public boolean esOpcionValida(String entrada, int cantidadOpciones) { | |||
| public boolean esOpcionValida(String ent, int cantidadOpciones) { | |||
| String entrada = ent; | |||
There was a problem hiding this comment.
esta es una reasignación inútil.
| try { | ||
| userProperties.store(new FileWriter(configFilePath), null); | ||
| } catch (IOException e) { | ||
| System.out.println("Couln't save settings: " + e); |
There was a problem hiding this comment.
esto es hacer más grande el issue #60 favor de corregirlo primero.
| for(String argumentos: args){ | ||
| if(argumentos.equals("no-gui")){ | ||
|
|
||
| if (args != null && args.length > 0) { |
There was a problem hiding this comment.
es mejor poner las constantes del lado izquierdo de una comparación
javatlacati
requested changes
Apr 18, 2021
|
|
||
| if (args != null && args.length > 0) { | ||
| for (String argumentos : args) { | ||
| if (argumentos.equals("no-gui")) { |
There was a problem hiding this comment.
constantes del lado izquierdo de la comparación
| return color.getRed() + "," + color.getGreen() + "," + color.getBlue(); | ||
| } | ||
|
|
||
| public static Color getColorXD(String propertyValue) { | ||
| public static Color getColorFromRGB(String propertyValue) { |
There was a problem hiding this comment.
Los métodos públicos deben llevar documentación
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resueltos muchos problemas pequeños detectados por el analizador de código estático, también refactoricé código duplicado.