Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong bit ordering in UART analyzer #122

Open
ghost opened this issue Oct 25, 2012 · 4 comments
Open

Wrong bit ordering in UART analyzer #122

ghost opened this issue Oct 25, 2012 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 25, 2012

See:
http://s12.postimage.org/4aoq2tfrx/uart_bug.png

Thre front byte bits are reversed, it should recognize 0b10101100 afaik

@jawi
Copy link
Owner

jawi commented Oct 25, 2012

From the image I cannot directly deduce what the supposed results should be; do you have a capture file for me to verify this?

@ghost
Copy link
Author

ghost commented Oct 25, 2012

Hey,

sorry, didn’t keep the testcase.. However, you can see it well on the image: the bits are sent LSB first, so “00110101”, now append start and stop bits: 0001101011.Thre first symbol is going almost exactly till the falling edge under the second time marker line. Divide it imaginary into 10 same length parts and you see it’s sent correctly.

Tell me if it helps – if not, I’ll reprogram my testboard and do the record once I have time.

PS having the “exact” baudrate is soo great about the analyzer, helped me a lot!

From: Jan Willem Janssen [mailto:notifications@github.com]
Sent: Thursday, October 25, 2012 10:19 AM
To: jawi/ols
Cc: Maverick89
Subject: Re: [ols] Wrong bit ordering in UART analyzer (#122)

From the image I cannot directly deduce what the supposed results should be; do you have a capture file for me to verify this?


Reply to this email directly or view it on GitHub #122 (comment) .

https://github.com/notifications/beacon/jeO1xPSnkeVf8skM755V4d_J1utDhj5Zx4ZBQYdJcmXbVpfZ3HzBzuuqgyeEo2vp.gif

@jawi
Copy link
Owner

jawi commented Oct 25, 2012

With your explanation it indeed seems a problem in the decoder. However, I'd like to verify this against "real" data in order to find the actual bug. So, if it wouldn't be much trouble, could you still provide me a capture file? I'd also like to add this file to the test cases of the decoder to keep this problem from reappearing in the future, is that ok with you?

@matthijskooijman
Copy link
Contributor

Scratch my last comment, bits are transmitted LSB first normally (I probably misremembered...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants