Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

翻訳: best-practices.md #39 #40

Merged
merged 3 commits into from Jul 23, 2022
Merged

翻訳: best-practices.md #39 #40

merged 3 commits into from Jul 23, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 22, 2022

No description provided.

@t-hamano t-hamano mentioned this pull request Jul 22, 2022
Closed
@t-hamano
Copy link
Member

issue: #39

t-hamano
t-hamano reviewed Jul 23, 2022
View reviewed changes
Copy link
Member

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳ありがとうございます！
二点レビューを残させていただきました。
こちらの提案で問題なければ「commit suggestion」を押下していただくか、他のご提案があればコメントいただければと思います。

core/best-practices.md Outdated Show resolved Hide resolved
core/best-practices.md Outdated Show resolved Hide resolved
Osamu Takahashi and others added 2 commits July 23, 2022 13:28
@t-hamano
Update core/best-practices.md
9954bc5 
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
@t-hamano
Update core/best-practices.md
df8ea24 
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
@t-hamano t-hamano merged commit b7adb38 into jawordpressorg:main Jul 23, 2022
@ghost ghost deleted the patch-4 branch July 30, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@t-hamano