Added support for PSR-3 compliant logger. #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zarko Stankovic <stankovic.zarko@gmail.com>
ManInTheBox
commented
Jul 3, 2017
|
|
||
| /** | ||
| * @requires PHP 5.4 | ||
| * @requires function uopz_backup |
There was a problem hiding this comment.
This is probably not needed. This test was failing for me because debug_backtrace() doesn't produce expected output by the code. I think that code needs refactoring in order for these test to be useful.
umpirsky
approved these changes
Nov 23, 2018
| @@ -137,4 +153,24 @@ public static function setColors(array $colors) | |||
| self::$colors[$k] = $v; | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * @param \Psr\Log\LoggerInterface $psr3Logger | |||
| } | ||
|
|
||
| /** | ||
| * @return \Psr\Log\LoggerInterface |
| @@ -122,8 +124,9 @@ class JAXL extends XMPPStream | |||
|
|
|||
| /** | |||
| * @param array $config | |||
| * @param LoggerInterface $psr3Logger | |||
There was a problem hiding this comment.
This is redundant and misleading. And incorrect, since null is allowed.
| @@ -154,6 +157,10 @@ public function __construct(array $config) | |||
| JAXLLogger::$level = $this->log_level = $this->cfg['log_level']; | |||
| JAXLLogger::$colorize = $this->log_colorize = $this->cfg['log_colorize']; | |||
|
|
|||
| if ($psr3Logger !== null) { | |||
There was a problem hiding this comment.
Alternatively we can allow null in setPsr3Logger() and remove if.
|
@ManInTheBox are we awaiting any further changes suggested by @umpirsky? If not I'll merge this in. Thank You!!! |
|
Thanks @umpirsky and @abhinavsingh! I'll update the code and let you know when it's ready for merging. |
|
This is really outdated. Discarding. Feel free to reopen if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to use PSR-3 compliant logger alongside JAXL's logging service implementation.
JAXL logging implementation is not modified, and logging levels are properly mapped to the ones defined by PSR-3.
Feel free to suggest better design implementation than the one I presented here.
Thanks!