Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added write callback in order to listen for write requests. #91

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

ManInTheBox
Copy link
Contributor

When JAXL is started it runs in an infinite loop, until there are no more active read/write file descriptors. Reading is fine because stream remains opened and data can come easily. However, writing is not that easy: you need to call send() in order to initiate writing data.

This PR adds ability to register your own write callback. It's being invoked on every loop cycle (the same as read callbacks) and it allows you to send data from your code.

Prior to this PR once connection is established you could only listed for incoming requests, and then respond to them. With this PR now you can write data without the need to wait for incoming message first.

If you like this idea I could add the docs as well.

@umpirsky
Copy link

umpirsky commented Jan 16, 2018

@abhinavsingh @frost-nzcr4 Ping, is this library still maintained?

Copy link

@umpirsky umpirsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like no BC breaks here. 👌

@abhinavsingh abhinavsingh merged commit f835200 into jaxl:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants