Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preload SSR API for React v16.6 #11

Closed
jaydenseric opened this issue Oct 25, 2018 · 0 comments
Closed

Fix preload SSR API for React v16.6 #11

jaydenseric opened this issue Oct 25, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@jaydenseric
Copy link
Owner

React v16.6 has some breaking changes to the way the new context API works, causing errors and warnings when attempting to use the preload SSR API, such as:

Warning: Rendering <Context.Consumer.Consumer> is not supported and will be removed in a future major release. Did you mean to render <Context.Consumer> instead?
Warning: Failed prop type: The prop `graphql` is marked as required in `GraphQLQuery`, but its value is `undefined`.
Error: Cannot read property 'constructor' of undefined
      at new GraphQLQuery (file://lib/components.mjs:57:42)

I suspect react-apollo will encounter issues too: apollographql/react-apollo#2530

@jaydenseric jaydenseric added the bug Something isn't working label Oct 25, 2018
@jaydenseric jaydenseric reopened this Oct 26, 2018
jaydenseric added a commit that referenced this issue Oct 27, 2018
RyanWooldridge added a commit to RyanWooldridge/React-graphql that referenced this issue Aug 21, 2019
RyanWooldridge added a commit to RyanWooldridge/React-graphql that referenced this issue Aug 21, 2019
denisp22 added a commit to denisp22/graphql-react that referenced this issue Jul 27, 2023
denisp22 added a commit to denisp22/graphql-react that referenced this issue Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant