Skip to content

Commit

Permalink
Increase gsharedvt trampolines by 10% from 4000 to 4400.
Browse files Browse the repository at this point in the history
Eventually this stuff should be fully dynamic, but where it
really counts -- iOS -- it already is. Otherwise is testing only,
i.e. FullAOT on platforms that allow JIT.

There are many minor arguments here.

Arguably we should JIT these.
Either w/o a fixed pool, or when the pool is depleted.
But that defeats the test coverage.

The test coverage is partial in any case, but the current
approach probably best approximates iOS.

Mitigates mono#13888.
If this feels too tenative, go bigger.
  • Loading branch information
Jay Krell committed Apr 11, 2019
1 parent 72c8776 commit c82ca86
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion configure.ac
Expand Up @@ -1258,7 +1258,8 @@ with_bitcode_default=no
enable_cooperative_suspend_default=no
enable_hybrid_suspend_default=no

INVARIANT_AOT_OPTIONS=nimt-trampolines=2000,ntrampolines=10000,nrgctx-fetch-trampolines=256,ngsharedvt-trampolines=4000,nftnptr-arg-trampolines=4000
# For the sake of clearer error messages, these numbers should all be different from each other.
INVARIANT_AOT_OPTIONS=nimt-trampolines=2000,ntrampolines=10000,nrgctx-fetch-trampolines=256,ngsharedvt-trampolines=4400,nftnptr-arg-trampolines=4000

AOT_BUILD_ATTRS=$INVARIANT_AOT_OPTIONS

Expand Down

0 comments on commit c82ca86

Please sign in to comment.