Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove open source label from Keka #988

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Remove open source label from Keka #988

merged 2 commits into from
Nov 10, 2021

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Oct 31, 2021

NOTE: A similar PR may already be submitted! Please search among the Pull request before creating one.

Types of Changes

What types of changes does your PR introduce? Put an x in all boxes that apply

  • New addition to list
  • Fixing bug in existing item in list
  • Removing item from list
  • Changing structure (organization) of list

Proposed Changes

Describe each of your changes here to communicate to the maintainers why we should accept this pull request.

From the project README:

Keka started in SourceForge as an open source project. Since 1.0 is a closed code project (one of the reasons) and there're no plans to open the code again.

Don't get me wrong, I love Keka, and it will probably remain free forever, but the fact it is no longer open source is also true. The labels should reflect the latest info.

PR Checklist

Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING guide
  • I have explained why this PR is important
  • I have added necessary documentation (if appropriate)

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jaywcjlove jaywcjlove merged commit aac5678 into jaywcjlove:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants