Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic auth support #32

Merged
merged 6 commits into from
Jan 11, 2023
Merged

Basic auth support #32

merged 6 commits into from
Jan 11, 2023

Conversation

tnyeanderson
Copy link
Contributor

@tnyeanderson tnyeanderson commented Dec 8, 2022

I don't want to have to put my password in the URL as a post parameter. Using basic auth leverages existing webhook_configs[].http_config.basic_auth.password_file option to read the password from a file instead (allowing me to check my alertmanager config into git!)

Username must be alertmanager. Password is the same as the APP_ALERTMANAGER_SECRET environment variable.

So far untested, just wanted to get the PR in.

src/utils.js Outdated Show resolved Hide resolved
src/utils.js Show resolved Hide resolved
@tnyeanderson
Copy link
Contributor Author

Fixed some stuff, thanks :) Still waiting on getting the baseline (with query parameter) working as I'm setting up alertmanager for the first time here. Until then I won't be able to validate this... Hoping to get it working this weekend. If anyone else wants to give it a shot and see if it works in the meantime, feel free!

@tnyeanderson
Copy link
Contributor Author

Just tested it and seems to be working for me!

@tnyeanderson tnyeanderson marked this pull request as ready for review December 13, 2022 05:36
@tnyeanderson
Copy link
Contributor Author

Hey @jaywink! Just wanted to ping to make sure this doesn't fall off the radar with all the craziness of the new year. Hope you are well and have a chance to look at this sometime soon. Thanks! :)

@jaywink
Copy link
Owner

jaywink commented Jan 11, 2023

Thanks for reminding, this indeed did fall of the radar :) Thank you for your contribution @tnyeanderson, looks good!

@jaywink jaywink merged commit cb57633 into jaywink:master Jan 11, 2023
@tnyeanderson tnyeanderson deleted the basic-auth branch May 31, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants