Fix completion if word-to-complete contains colon (:) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recommended way to handle colons in completion words
is by using the helper methods:
* _get_comp_words_by_ref with the -n : option
gets the word-to-complete without considering a colon as a word break
* __ltrim_colon_completions
removes colon containing prefix from COMPREPLY items
(a workaround for http://tiswww.case.edu/php/chet/bash/FAQ - E13)
Using the helper methods also simplifies the script and
ensures that we get the same behavior on any environment.
|
Great, thank you for the fix. |
jaz303
added a commit
that referenced
this pull request
Sep 19, 2012
Fix completion if word-to-complete contains colon (:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommended way to handle colons in completion words
is by using the helper methods:
gets the word-to-complete without considering a colon as a word break
removes colon containing prefix from COMPREPLY items
(a workaround for http://tiswww.case.edu/php/chet/bash/FAQ - E13)
Using the helper methods also simplifies the script and
ensures that we get the same behavior on any environment.
Tested on Ubuntu 12.04, Red Hat 5 and 6.