-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live to on #144
base: master
Are you sure you want to change the base?
Live to on #144
Conversation
the "live option" doesn't work for me. $('a.live-tipsy').tipsy({live: true});
$('#btn').on('click', function(e) {
$('body').append('<a href="#" class="live-tipsy" title="A tooltip">Dynamic tooltip</a>');
e.preventDefault();
}); |
@attaboy the latest commits are not fixing the jquery 1.9 "live" issue Plus, now the latest version of jquery is 1.10.2, your variable majorVersionNumber is wrong and is set to 1.1. Which forces tipsy to use the live event. Here is a solution:
|
@taitems humm... I can see that you just changed one variable in my code. Mentioning it would have been enough. |
@bernier wellllll, yes and no.
Considering this project doesn't appear to be maintained any more, the driver should be creating clean simple pulls that require little to no thought for the project owner to merge (if they see fit, or are still watching). |
@@ -174,7 +183,7 @@ | |||
if (!options.live) this.each(function() { get(this); }); | |||
|
|||
if (options.trigger != 'manual') { | |||
var binder = options.live ? 'live' : 'bind', | |||
var binder = options.live ? jQueryDelegateEventMethod() : 'bind', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace jQueryDelegateEventMethod()
with ('on' in this ? 'on' : 'live')
Patches Tipsy's "live" option to work with newer versions of jQuery by using the 'on' method to bind events instead of 'live'.