Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic theming support #14

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Basic theming support #14

merged 3 commits into from
Jul 4, 2023

Conversation

Andrew-J-Larson
Copy link
Contributor

Allows changing various aspects of the player, from colors, to the curve on buttons (border-radius).

Allows changing various aspects of the player, from colors, to the curve on buttons (border-radius).
@coveralls
Copy link

coveralls commented Jul 4, 2023

Pull Request Test Coverage Report for Build 5454429489

  • 45 of 47 (95.74%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 65.29%

Changes Missing Coverage Covered Lines Changed/Added Lines %
javascript/JZZ.gui.Player.js 45 47 95.74%
Files with Coverage Reduction New Missed Lines %
javascript/JZZ.gui.Player.js 1 65.29%
Totals Coverage Status
Change from base Build 5450560699: -0.1%
Covered Lines: 415
Relevant Lines: 549

💛 - Coveralls

I thought lbl needed a backgroundColor element too, but didn't think that the gui backgroundColor would already take care of it.
Separates container's styling from the rail/caret, plus adds one more style attribute to the container (border-radius ... curves are nice what can I say? `¯\_(ツ)_/¯`)
@jazz-soft jazz-soft merged commit 753cbc0 into jazz-soft:master Jul 4, 2023
1 of 2 checks passed
@Andrew-J-Larson Andrew-J-Larson deleted the patch-5 branch July 4, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants