New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altered for...in statements to check obj.hasOwnProperty(index) #1

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
2 participants
@platywompus
Contributor

platywompus commented Nov 29, 2017

*this check prevents for...in's from finding prototyped functions. ie. if someone adds the common "Array.prototype.find = ..." method, this check prevents it from getting called along with the intended member functions/objects

See this thread: http://jazz-soft.org/bb/viewtopic.php?f=9&t=954

Altered for...in statements to check obj.hasOwnProperty(index)
*this check prevents for...in's from finding prototyped functions. ie. if someone adds the common "Array.prototype.find = ..." method, this check prevents it from getting called along with the intended member functions/objects

@jazz-soft jazz-soft merged commit 6b9e2c8 into jazz-soft:master Nov 30, 2017

@jazz-soft

This comment has been minimized.

Show comment
Hide comment
@jazz-soft

jazz-soft Nov 30, 2017

Owner

Thanks a lot platywompus!

Owner

jazz-soft commented Nov 30, 2017

Thanks a lot platywompus!

jazz-soft pushed a commit that referenced this pull request Aug 13, 2018

Merge pull request #1 from abudaan/abudaan-patch-1
Fix never resolving Promise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment