Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very high idle CPU usage #1

Closed
DoctorMcKay opened this issue Jun 23, 2020 · 1 comment
Closed

Very high idle CPU usage #1

DoctorMcKay opened this issue Jun 23, 2020 · 1 comment

Comments

@DoctorMcKay
Copy link

DoctorMcKay commented Jun 23, 2020 •
edited
Loading

I am running a lighting control system off a Raspberry Pi, which has never been an issue before. I've added a MIDI controller to my system using this module, and I've run into an issue where the CPU idles very high with this module. I've confirmed that jazz-midi is the culprit as using node-midi with the exact same code doesn't exhibit the same behavior.

I'm using the latest version 1.7.3, and I've encountered this on both Raspbian and Ubuntu 18.04.4 LTS (on a Core 2 Duo machine).
@jazz-soft
Copy link
Owner

I have published the source code in this repository. If you have any suggestions how to improve it, please let me know!

thirtythreeforty added a commit to thirtythreeforty/jazz-midi that referenced this issue Oct 10, 2023
@thirtythreeforty
MidiALSA: Fix crash when snd_seq_subscribe_port fails
c1ba6da 
The pthread and lock are never created if the "if" in the constructor
fails, and the members are never initialized.  But the destructor
unconditionally destroys them.  Fix this by adding a guard flag.

This fixes a segfault I encountered on Arch with Pipewire as the ALSA
server.

    Thread 1 "node" received signal SIGSEGV, Segmentation fault.
    0x00007ffff428aebd in pthread_cancel () from /usr/bin/../lib/libc.so.6
    (gdb) bt
    #0  0x00007ffff428aebd in pthread_cancel () from /usr/bin/../lib/libc.so.6
    jazz-soft#1  0x00007ffff3b773ff in CMidiInHW::~CMidiInHW (this=0x55555572a430, __in_chrg=<optimized out>) at ../../midi/MidiALSA.cpp:366
    jazz-soft#2  0x00007ffff3b77452 in CMidiInHW::~CMidiInHW (this=0x55555572a430, __in_chrg=<optimized out>) at ../../midi/MidiALSA.cpp:369
    jazz-soft#3  0x00007ffff3b77105 in CMidiALSA::MidiInOpen[abi:cxx11](wchar_t const*, void*) (this=0x5555557b9880, name=0x5555556b3cf0 L"input", p=0x55555579e3a0) at ../../midi/MidiALSA.cpp:329
    jazz-soft#4  0x00007ffff3b6f0c8 in MidiInOpen (env=0x55555579e410, args=0x7fffffff9e20) at ../jazz-midi.cpp:461
    jazz-soft#5  0x00007ffff535bd33 in ?? () from /usr/bin/../lib/libnode.so.115
    jazz-soft#6  0x00007ffff5840d97 in ?? () from /usr/bin/../lib/libnode.so.115
    jazz-soft#7  0x00007ffff5841942 in v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) () from /usr/bin/../lib/libnode.so.115
    jazz-soft#8  0x00007ffff56cadf6 in ?? () from /usr/bin/../lib/libnode.so.115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DoctorMcKay @jazz-soft