-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox plugin is (probably) broken now #3
Comments
After reinstalling it's OK. |
thirtythreeforty
added a commit
to thirtythreeforty/jazz-midi
that referenced
this issue
Oct 10, 2023
The pthread and lock are never created if the "if" in the constructor fails, and the members are never initialized. But the destructor unconditionally destroys them. Fix this by adding a guard flag. This fixes a segfault I encountered on Arch with Pipewire as the ALSA server. Thread 1 "node" received signal SIGSEGV, Segmentation fault. 0x00007ffff428aebd in pthread_cancel () from /usr/bin/../lib/libc.so.6 (gdb) bt #0 0x00007ffff428aebd in pthread_cancel () from /usr/bin/../lib/libc.so.6 jazz-soft#1 0x00007ffff3b773ff in CMidiInHW::~CMidiInHW (this=0x55555572a430, __in_chrg=<optimized out>) at ../../midi/MidiALSA.cpp:366 jazz-soft#2 0x00007ffff3b77452 in CMidiInHW::~CMidiInHW (this=0x55555572a430, __in_chrg=<optimized out>) at ../../midi/MidiALSA.cpp:369 jazz-soft#3 0x00007ffff3b77105 in CMidiALSA::MidiInOpen[abi:cxx11](wchar_t const*, void*) (this=0x5555557b9880, name=0x5555556b3cf0 L"input", p=0x55555579e3a0) at ../../midi/MidiALSA.cpp:329 jazz-soft#4 0x00007ffff3b6f0c8 in MidiInOpen (env=0x55555579e410, args=0x7fffffff9e20) at ../jazz-midi.cpp:461 jazz-soft#5 0x00007ffff535bd33 in ?? () from /usr/bin/../lib/libnode.so.115 jazz-soft#6 0x00007ffff5840d97 in ?? () from /usr/bin/../lib/libnode.so.115 jazz-soft#7 0x00007ffff5841942 in v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) () from /usr/bin/../lib/libnode.so.115 jazz-soft#8 0x00007ffff56cadf6 in ?? () from /usr/bin/../lib/libnode.so.115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I tried removing jazz-midi and installing it again, to test how to instruct users of my software to use MIDI in Firefox.
However this broke my setup and MIDI is not working in Firefox anymore.
I think that your build system is probably broken now. I looked into
about:debugging#/runtime/this-firefox
and when inspecting extensions there seems to be missingbackground.js
file and profile directory.See screenshots:
Also do I understand correctly, that in order to have working Web MIDI on Firefox you need to install three different things?
I somewhat understand why this is a thing but I think it may be confusing for non-techie users.
(This is why I went to whole reinstalling thing.)
Aside from this bug Jazz plugin and JZZ.js always worked well for me. Good job!
The text was updated successfully, but these errors were encountered: