Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended IntegerValue to only allow positive integers #186

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

MikeWooster
Copy link
Contributor

I have recently identified a requirement when working with django-configurations where I needed only a positive integer value. I thought others may benefit from this feature too.

@codecov
Copy link

codecov bot commented Dec 10, 2017

Codecov Report

Merging #186 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   88.18%   88.33%   +0.14%     
==========================================
  Files          23       23              
  Lines        1143     1157      +14     
  Branches      104      105       +1     
==========================================
+ Hits         1008     1022      +14     
  Misses        106      106              
  Partials       29       29
Flag Coverage Δ
#dj110 87.72% <100%> (+0.15%) ⬆️
#dj111 87.98% <100%> (+0.14%) ⬆️
#dj18 88.07% <100%> (+0.14%) ⬆️
#dj20 86.77% <100%> (+0.16%) ⬆️
#djmaster 86.77% <100%> (+0.16%) ⬆️
#py27 87.64% <100%> (+0.15%) ⬆️
#py34 87.12% <100%> (+0.15%) ⬆️
#py35 87.12% <100%> (+0.15%) ⬆️
#py36 87.12% <100%> (+0.15%) ⬆️
#pypy 87.64% <100%> (+0.15%) ⬆️
Impacted Files Coverage Δ
configurations/values.py 95.11% <100%> (+0.09%) ⬆️
tests/test_values.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e2d3e...377205f. Read the comment docs.

@blueyed blueyed merged commit 1c6fd0f into jazzband:master Mar 15, 2018
@blueyed
Copy link
Contributor

blueyed commented Mar 15, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants