Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ugettext_lazy with gettext_lazy #342

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

sumanthratna
Copy link
Member

when running python3 -Wd manage.py runserver in my Django 3.0 project, I see:

venv/lib/python3.8/site-packages/dbbackup/apps.py:12: RemovedInDjango40Warning: django.utils.translation.ugettext_lazy() is deprecated in favor of django.utils.translation.gettext_lazy().
  verbose_name = _('Backup and restore')
/venv/lib/python3.8/site-packages/dbbackup/apps.py:12: RemovedInDjango40Warning: django.utils.translation.ugettext_lazy() is deprecated in favor of django.utils.translation.gettext_lazy().
  verbose_name = _('Backup and restore')

I'm unsure of any unintended consequences, but gettext_lazy has been available since Django 1.8 or earlier

@jonathan-s
Copy link
Contributor

Thank you for fixing this @sumanthratna, gettext_lazy is an alias for ugettext_lazy there should not be any issues with this.

@jonathan-s jonathan-s merged commit bec499e into jazzband:master Sep 19, 2020
@sumanthratna sumanthratna deleted the patch-1 branch September 19, 2020 18:07
@johnthagen
Copy link
Contributor

johnthagen commented Dec 21, 2020

@jonathan-s Would it be possible to get a new minor release with this fix published to PyPI? We run our tests with -Werror and this requires us to add some suppressions (We are running Django 3.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants