Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication error when postgres is password protected #361

Merged
merged 6 commits into from
Oct 31, 2020

Conversation

jonathan-s
Copy link
Contributor

Fixes #282

@jonathan-s jonathan-s marked this pull request as draft October 29, 2020 10:17
@jonathan-s jonathan-s added this to the 3.4.0 milestone Oct 29, 2020
@jonathan-s jonathan-s marked this pull request as ready for review October 29, 2020 17:13
@jonathan-s
Copy link
Contributor Author

@NoahRR Hey there, I saw that you had issues with #282, would you mind trying out this branch and see if it works for you?

@jonathan-s jonathan-s changed the title WIP: Fix authentication error when postgres is password protected Fix authentication error when postgres is password protected Oct 29, 2020
@jonathan-s
Copy link
Contributor Author

Should add a testcase for this too -> https://dba.stackexchange.com/a/243220/132631

@ZuluPro
Copy link
Contributor

ZuluPro commented Oct 30, 2020

👍🏾

@NoahRR
Copy link

NoahRR commented Oct 30, 2020

@NoahRR Hey there, I saw that you had issues with #282, would you mind trying out this branch and see if it works for you?

@jonathan-s Hey, yeah I'd love to. Sorry, I'm new to the programming world, how would I actually download this new branch to test if it works? I KNOW REALLY NOOB QUESTION xD

@NoahRR
Copy link

NoahRR commented Oct 30, 2020

@NoahRR Hey there, I saw that you had issues with #282, would you mind trying out this branch and see if it works for you?

@jonathan-s Hey, yeah I'd love to. Sorry, I'm new to the programming world, how would I actually download this new branch to test if it works? I KNOW REALLY NOOB QUESTION xD

scratch that... I see the branch now xD. Let me test it

@NoahRR
Copy link

NoahRR commented Oct 30, 2020

nope, I'm still a dumbass :). I cloned repo and checked out password branch, but how do I actually "install" it so I can test the new functionality. @jonathan-s I know you probably have more important things to do but I'd love to test this branch if I could >.<

@jonathan-s
Copy link
Contributor Author

@NoahRR Nothing wrong with being a noob, we all were at some point.

So you've cloned the repo and also changed the branch to password. Great! Half-way there. If you go to the folder where the cloned repo is (ie you see setup.py when you type ls -l in the command line). You should be able to type pip install -e . that would install the package in editable mode (which is excellent way of developing python packages :) ). It's pip installed and is now available everywhere you can access all the other packages that were installed the same way.

@NoahRR
Copy link

NoahRR commented Oct 30, 2020

@jonathan-s I really appreciate the help (now i understand how that works)!

The new branch seems to have solved the password problem!

... I'm still running into errors, but I believe those are due to Postgres permissions (error: permission denied for schema topology). Anyways, I don't think that is relevant and shouldn't be too hard to fix on my part. The --no-password errors are gone!

@jonathan-s
Copy link
Contributor Author

Great to hear @NoahRR, and thanks for verifying that it works as expected.

jonathan-s added a commit that referenced this pull request Nov 4, 2020
@sumanthratna sumanthratna mentioned this pull request Dec 7, 2020
2 tasks
jonathan-s added a commit that referenced this pull request Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Which is USERNAME and PASSWORD should I put no DBBACKUP_CONNECTORS?
3 participants