Env password is no longer used since #361 (#362)

jazzband · Dec 13, 2020 · e603f16 · e603f16
1 parent b8d4e2b
commit e603f16
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/dbbackup/db/postgresql.py b/dbbackup/db/postgresql.py
@@ -38,13 +38,6 @@ class PgDumpConnector(BaseCommandDBConnector):
     single_transaction = True
     drop = True
 
-    def run_command(self, *args, **kwargs):
-        if self.settings.get('PASSWORD'):
-            env = kwargs.get('env', {})
-            env['PGPASSWORD'] = utils.get_escaped_command_arg(self.settings['PASSWORD'])
-            kwargs['env'] = env
-        return super(PgDumpConnector, self).run_command(*args, **kwargs)
-
     def _create_dump(self):
         cmd = '{} '.format(self.dump_cmd)
         cmd = cmd + create_postgres_uri(self)

diff --git a/dbbackup/tests/test_connectors/test_postgresql.py b/dbbackup/tests/test_connectors/test_postgresql.py
@@ -250,8 +250,6 @@ def test_run_command_with_password(self, mock_popen):
         connector.settings['PASSWORD'] = 'foo'
         connector.create_dump()
         self.assertEqual(mock_popen.call_args[0][0][0], 'pg_dump')
-        self.assertIn('PGPASSWORD', mock_popen.call_args[1]['env'])
-        self.assertEqual('foo', mock_popen.call_args[1]['env']['PGPASSWORD'])
 
     def test_run_command_with_password_and_other(self, mock_popen):
         connector = PgDumpConnector(env={'foo': 'bar'})
@@ -261,5 +259,3 @@ def test_run_command_with_password_and_other(self, mock_popen):
         self.assertEqual(mock_popen.call_args[0][0][0], 'pg_dump')
         self.assertIn('foo', mock_popen.call_args[1]['env'])
         self.assertEqual('bar', mock_popen.call_args[1]['env']['foo'])
-        self.assertIn('PGPASSWORD', mock_popen.call_args[1]['env'])
-        self.assertEqual('foo', mock_popen.call_args[1]['env']['PGPASSWORD'])