Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a parameter to configure if cleaning the database during a backup… #400

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add a parameter to configure if cleaning the database during a backup… #400

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aca3fd
Add a parameter to configure if cleaning the database during a backup…
emilianoberonich Oct 20, 2021
38ad303
Merge branch 'master' into nodrop_database_option
Archmonger Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions dbbackup/management/commands/dbrestore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,23 @@ class Command(BaseDbBackupCommand):
help = """Restore a database backup from storage, encrypted and/or
compressed."""
content_type = 'db'
nodrop = False

option_list = BaseDbBackupCommand.option_list + (
make_option("-d", "--database", help="Database to restore"),
make_option("-i", "--input-filename", help="Specify filename to backup from"),
make_option("-I", "--input-path", help="Specify path on local filesystem to backup from"),
make_option("-s", "--servername",
help="If backup file is not specified, filter the "
"existing ones with the given servername"),
help="If backup file is not specified, filter the "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unneeded formatting changes from this PR.

"existing ones with the given servername"),
make_option("-c", "--decrypt", default=False, action='store_true',
help="Decrypt data before restoring"),
make_option("-p", "--passphrase", help="Passphrase for decrypt file", default=None),
make_option("-p", "--passphrase",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unneeded formatting changes from this PR.

help="Passphrase for decrypt file", default=None),
make_option("-z", "--uncompress", action='store_true', default=False,
help="Uncompress gzip data before restoring")
help="Uncompress gzip data before restoring"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unneeded formatting changes from this PR.

make_option("-r", "--nodrop", action="store_true",
default=False, help="Don't clean (drop) database",)
)

def handle(self, *args, **options):
Expand All @@ -50,6 +54,7 @@ def handle(self, *args, **options):
self.interactive = options.get('interactive')
self.database_name, self.database = self._get_database(options)
self.storage = get_storage()
self.nodrop = options.get("nodrop")
self._restore_backup()
except StorageError as err:
raise CommandError(err)
Expand Down Expand Up @@ -91,4 +96,5 @@ def _restore_backup(self):

input_file.seek(0)
self.connector = get_connector(self.database_name)
self.connector.drop = not self.nodrop
self.connector.restore_dump(input_file)