Add a parameter to configure if cleaning the database during a backup… #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eberonsh
force-pushed
the
nodrop_database_option
branch
from
a05dfb2
to
9e30344
Compare
eberonsh
force-pushed
the
nodrop_database_option
branch
from
9e30344
to
1aca3fd
Compare
Archmonger
requested changes
Dec 25, 2021
| make_option("-c", "--decrypt", default=False, action='store_true', | ||
| help="Decrypt data before restoring"), | ||
| make_option("-p", "--passphrase", help="Passphrase for decrypt file", default=None), | ||
| make_option("-p", "--passphrase", |
There was a problem hiding this comment.
Please remove unneeded formatting changes from this PR.
| make_option("-z", "--uncompress", action='store_true', default=False, | ||
| help="Uncompress gzip data before restoring") | ||
| help="Uncompress gzip data before restoring"), |
There was a problem hiding this comment.
Please remove unneeded formatting changes from this PR.
|
|
||
| option_list = BaseDbBackupCommand.option_list + ( | ||
| make_option("-d", "--database", help="Database to restore"), | ||
| make_option("-i", "--input-filename", help="Specify filename to backup from"), | ||
| make_option("-I", "--input-path", help="Specify path on local filesystem to backup from"), | ||
| make_option("-s", "--servername", | ||
| help="If backup file is not specified, filter the " | ||
| "existing ones with the given servername"), | ||
| help="If backup file is not specified, filter the " |
There was a problem hiding this comment.
Please remove unneeded formatting changes from this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… restoration.
#enhancement
Description
Add a parameter to the command dbrestore. This option allows to set if the connector sends or not a clean parameter in the restore command.
Fixes # (issue)
Why should this be added
The restore command sends by default a --clean argument and there is no option to remove it in case it is causing a problem with the restoration process.
Explain value.
Adding this option allows to control sending the --clean to the restore command in case of any trouble.