Rename SQLPanel context var to control SQL access. #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current build started failing for py3.8+ because the inner exception SQLQueryTriggered was raised in the test test_cursor_wrapper_asyncio_ctx. This was identified as being caused by sql.tracking.recording being set to false. The name recording made it seem as if this context var was controlling whether recording was occurring or not. However, it's true functionality was preventing SQL queries from being sent during the template panel's processing. Renaming that context var to allow_sql is more indicative of its purpose and makes the fixed test change clearer.
|
@matthiask if you're good with this name change, I'll merge this and #1614 and release a new version today. |
matthiask
approved these changes
May 3, 2022
13 tasks
|
if you are kind enough to look and shred some light into this probably unsupported issue... I'm trying to update it NixOS/nixpkgs#171764 from 3.2.4 to 3.4 i don't have familiarity with this from the python perspective, so i'm not sure what I'm supposed to do here other than disabling this test, even though i tried some things patching the code itself... |
|
@yuuyins sorry, I don't have nix installed and I don't have the availability to dive into it. However, I don't think disabling this test is the right move since it's there to verify the functionality. If it's breaking, then there's a problem somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current build started failing for py3.8+ because the inner
exception SQLQueryTriggered was raised in the test
test_cursor_wrapper_asyncio_ctx.
This was identified as being caused by sql.tracking.recording
being set to false. The name recording made it seem as if
this context var was controlling whether recording was occurring
or not. However, it's true functionality was preventing SQL
queries from being sent during the template panel's processing.
Renaming that context var to allow_sql is more indicative of
its purpose and makes the fixed test change clearer.