Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SQLPanel context var to control SQL access. #1615

Merged
merged 1 commit into from
May 3, 2022

Commits on May 3, 2022

  1. Rename SQLPanel context var to control SQL access.

    The current build started failing for py3.8+ because the inner
    exception SQLQueryTriggered was raised in the test
    test_cursor_wrapper_asyncio_ctx.
    
    This was identified as being caused by sql.tracking.recording
    being set to false. The name recording made it seem as if
    this context var was controlling whether recording was occurring
    or not. However, it's true functionality was preventing SQL
    queries from being sent during the template panel's processing.
    
    Renaming that context var to allow_sql is more indicative of
    its purpose and makes the fixed test change clearer.
    tim-schilling committed May 3, 2022
    Configuration menu
    Copy the full SHA
    c74386c View commit details
    Browse the repository at this point in the history