Test HTML of all panels is valid; fix invalid #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #947 +/- ##
=======================================
Coverage 83.14% 83.14%
=======================================
Files 28 28
Lines 1643 1643
Branches 249 249
=======================================
Hits 1366 1366
Misses 202 202
Partials 75 75Continue to review full report at Codecov.
|
|
Thank you! |
|
Would it be possible to get a new release that includes this fix? It is difficult for my project to upgrade django-debug-toolbar as the invalid HTML in the most recent release causes some integration test failures. Thanks! |
|
I just released 1.9. Thanks for all the work you put into this release! |
|
Thanks for the very quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of one-off commits have fixed invalid HTML:
Most recently, templates.html was discovered to contain invalid HTML. To
avoid regressions on valid HTML, add tests for valid HTML across many
panels.
Added new test dependency, html5lib.