Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated django.utils.importlib and replace with importlib #86

Merged
merged 1 commit into from Jan 10, 2017
Merged

Conversation

alitinker
Copy link

django.utils.importlib was removed in 1.9. Replaced with importlib. Noticed issue #85 references an error related to this. I don't know if you're still accepting pull requests for this...

django.utils.importlib was removed in 1.9. Replaced with importlib. Noticed issue #85 references an error related to this. Maybe you're no longer accepting pull requests but I'm interested in submitting some patches (like this one) if you are.
@garrypolley
Copy link
Collaborator

I'd be okay merging this change in, however, it means we no longer support Python 2.6, which I'm not against, but would be a major version increase.

https://docs.python.org/2.6/genindex-I.html <-- from reading that I don't think importlib is in Python 2.6, which we currenty support (or at least claim to support).

@dmarcelino
Copy link

dmarcelino commented Jul 20, 2016

@alitinker, @garrypolley, @gjain0 I'm also experiencing this, should we branch current master into 0.2 (for legacy purposes) and go for a new 0.3 version supporting django 1.9?

@garrypolley
Copy link
Collaborator

I'm fine if this gets merged.

@garrypolley
Copy link
Collaborator

I don't have time to test it at this moment, which is why I've not merged it yet.

@gauravvjn
Copy link

Can't we do something like below?

try:
    from django.utils.importlib import import_module
except ImportError: # for django >= 1.9
    from importlib import import_module

or if django.get_version() >= '1.9'

@garrypolley
Copy link
Collaborator

@gjain0 That works for me.

@garrypolley
Copy link
Collaborator

I like the import one the best.

@garrypolley
Copy link
Collaborator

Any care if I merge this?

It seems fine to me.

@garrypolley garrypolley merged commit ea11665 into jazzband:master Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants