Fix a regression in determining when to collect static files. #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A commit made in 1.6.10 (ae6b3f8) changed a storage lookup to use the prefixed_path variable instead of the path variable when looking up modification times in order to determine if an existing collected file should be deleted and re-collected. By using the wrong path variable, the storage lookups always failed, resulting in every single file being re-collected every single time. This reduces performance considerably, particularly with large codebases. Since every file ends up copied, they appear as new and are recompiled. This can result in very long page reloads on a development server, especially if working on an older machine, in a VM, on a shared filesystem, or on the Linux subsystem for Windows. This is a simple change that fixes the lookup to use the correct variable. Unit tests were added to ensure this continues to work as expected and does not regress.
cyberdelia
approved these changes
Dec 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A commit made in 1.6.10 (ae6b3f8)
changed a storage lookup to use the prefixed_path variable instead of
the path variable when looking up modification times in order to
determine if an existing collected file should be deleted and
re-collected. By using the wrong path variable, the storage lookups
always failed, resulting in every single file being re-collected every
single time.
This reduces performance considerably, particularly with large codebases.
Since every file ends up copied, they appear as new and are recompiled.
This can result in very long page reloads on a development server,
especially if working on an older machine, in a VM, on a shared
filesystem, or on the Linux subsystem for Windows.
This is a simple change that fixes the lookup to use the correct
variable. Unit tests were added to ensure this continues to work as
expected and does not regress.