Replace Travis CI configuration with GitHub Actions #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2023
|
@j-antunes Yes, #560 + this effectively replace #558, but this uses the current Tox configuration to test against various Django and Python versions, which didn't happen in #558. |
j-antunes
approved these changes
Dec 11, 2023
|
Sounds good! Everything looks good on the PR. I'll wait for @AdamDonna to check it, to have a second set of eyes on it. Again, thanks for your work! |
hugovk
reviewed
Dec 11, 2023
hugovk
reviewed
Dec 11, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
approved these changes
Dec 11, 2023
|
I'll just go ahead and merge this since there's 2 approvals 👍 |
This was referenced Dec 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the defunct Travis CI configuration and replaces it with a near-minimal GitHub Actions workflow.
There are some things still left undone (e.g. testing on Postgres again, and testing against the current django
main(néemaster) revision, but I think this is a good start; I added relevantTODOmarkers to follow up on.It also adds testing on Django 4.1 and 4.2.
(Following this, I think the next version of
django-polymorphicshould drop testing and support on EOL versions of Python and Django.)