New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: UUID field support #54
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ Setup development environment | |
* Requires supported Python version | ||
* do setup under django-redshift-backend.git repository root as:: | ||
|
||
$ pip install -U pip setuptools wheel setuotools_scm | ||
$ pip install -U pip setuptools wheel setuptools_scm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! I've applied this line at ff5c1cb |
||
$ pip install -r dev-requires.txt | ||
|
||
Testing | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,6 +70,20 @@ def test_annotate(self): | |
sql = norm_sql(compiler.as_sql()[0]) | ||
self.assertEqual(sql, expected_dml_annotate) | ||
|
||
def test_insert_uuid_field(self): | ||
import uuid | ||
from django.db.models import sql | ||
from testapp.models import TestModel | ||
obj = TestModel(uuid=uuid.uuid4()) | ||
q = sql.InsertQuery(obj) | ||
q.insert_values(obj._meta.local_fields, [obj]) | ||
statements = q.get_compiler('default').as_sql() | ||
# uuid is the last field of TestModel | ||
uuid_insert_value = statements[0][1][-1] | ||
# the Python value for insertion must be a string whose length is 32 | ||
self.assertEqual(type(uuid_insert_value), str) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
self.assertEqual(len(uuid_insert_value), 32) | ||
|
||
|
||
class MigrationTest(unittest.TestCase): | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memo: This class variable has been introduced at Django-1.8.0 django/django@39d95fb
With django 1.11, 2.0 and 2.1:
https://github.com/django/django/blob/838e432e3e5519c5383d12018e6c78f8ec7833c1/django/db/models/fields/__init__.py#L2317-L2319