Fix: UUID field support #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDIL
approved these changes
Jan 10, 2019
|
Thanks! I'll take a look in this weekend. |
shimizukawa
approved these changes
Jan 21, 2019
| @@ -36,6 +36,7 @@ class DatabaseFeatures(BasePGDatabaseFeatures): | |||
| supports_column_check_constraints = False | |||
| can_distinct_on_fields = False | |||
| allows_group_by_selected_pks = False | |||
| has_native_uuid_field = False | |||
There was a problem hiding this comment.
Memo: This class variable has been introduced at Django-1.8.0 django/django@39d95fb
With django 1.11, 2.0 and 2.1:
https://github.com/django/django/blob/838e432e3e5519c5383d12018e6c78f8ec7833c1/django/db/models/fields/__init__.py#L2317-L2319
| @@ -20,7 +20,7 @@ Setup development environment | |||
| * Requires supported Python version | |||
| * do setup under django-redshift-backend.git repository root as:: | |||
|
|
|||
| $ pip install -U pip setuptools wheel setuotools_scm | |||
| $ pip install -U pip setuptools wheel setuptools_scm | |||
There was a problem hiding this comment.
Thanks! I've applied this line at ff5c1cb
| # uuid is the last field of TestModel | ||
| uuid_insert_value = statements[0][1][-1] | ||
| # the Python value for insertion must be a string whose length is 32 | ||
| self.assertEqual(type(uuid_insert_value), str) |
|
I'm sorry for my late reply. |
shimizukawa
added a commit
that referenced
this pull request
Jan 21, 2019
|
All right, thanks for merging this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Fix for the
UUIDFieldsupportFeature or Bugfix
Purpose
UUIDFieldin Redshift.UUIDField. We should check that the type of the Python argument isstr(as opposed touuid.UUID) and its length is 32.Detail
UUIDFieldwhen used in Redshift (should be astr, i.e. the value ofUUID.hex)Relates