Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(migration): use f-string #317

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Oct 10, 2023

Just some migrations to modern python.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dd7b062) 91.70% compared to head (af386f9) 91.70%.

Files Patch % Lines
knox/models.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #317   +/-   ##
========================================
  Coverage    91.70%   91.70%           
========================================
  Files            9        9           
  Lines          229      229           
  Branches        35       35           
========================================
  Hits           210      210           
  Misses          16       16           
  Partials         3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rotzbua Rotzbua changed the title chore(migration): use f-string; no arguments for super() chore(migration): use f-string Dec 23, 2023
Copy link
Contributor

@giovannicimolin giovannicimolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good. Codecov is complaining about coverage but it's for the __str__ method.

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Jan 27, 2024

I rebased again, because the github rebase changed more lines of code.
I do not know why codecov complains because it is basically the same. Do you know the reason?

@giovannicimolin
Copy link
Contributor

@Rotzbua It's complained because of the changed lines is not covered by any tests. It's ok though.

Thanks for the PR! 😁

@giovannicimolin giovannicimolin merged commit ad1eca6 into jazzband:develop Jan 27, 2024
9 of 10 checks passed
@Rotzbua Rotzbua deleted the chore_migration branch January 27, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants