Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.0 support #85

Closed
wants to merge 1 commit into from
Closed

Conversation

mpasternak
Copy link

No description provided.

@mpasternak mpasternak mentioned this pull request Dec 11, 2017
7 tasks
@tony
Copy link
Member

tony commented Dec 11, 2017

Wow. I just merged my part of the branch in, and didn't see yours.

@codecov
Copy link

codecov bot commented Dec 11, 2017

Codecov Report

Merging #85 into master will decrease coverage by 1.72%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   65.69%   63.97%   -1.73%     
==========================================
  Files           7        5       -2     
  Lines         137      136       -1     
  Branches       15       15              
==========================================
- Hits           90       87       -3     
- Misses         41       43       +2     
  Partials        6        6
Impacted Files Coverage Δ
robots/views.py 72.05% <50%> (-1.79%) ⬇️
robots/south_migrations/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5362e...07194b9. Read the comment docs.

@tony
Copy link
Member

tony commented Dec 11, 2017

As in, I see this now, but didn't check before for a duplicate before I merged. Then I saw you posted in my issue when the tab was open. It was that close.

@mpasternak
Copy link
Author

@tony whatever. Good job everyone involved, let's merge, release, upload!

@mpasternak mpasternak closed this Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants