Modernize middleware #296
Merged
Modernize middleware #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As django-silk no longer supports django < 1.10 the MiddlewareMixin is no longer needed.
albertyw
approved these changes
Jul 22, 2018
silk/middleware.py
Outdated
| @@ -57,7 +56,19 @@ def process_request(self, request): | |||
| return | |||
|
|
|||
|
|
|||
| class SilkyMiddleware(MiddlewareMixin): | |||
| class SilkyMiddleware(object): | |||
There was a problem hiding this comment.
This shouldn't need to inherit from object anymore since we are now python 3.
There was a problem hiding this comment.
Thanks for the review, indeed, that is no longer needed.
Unfortunately I'm going on vacations and I can not fix that myself, I could gladly do that as soon as I'm back around August 15th
|
@albertyw I fixed your review. Would you mind getting another look? TIA! |
|
@avelis thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As django-silk no longer supports django < 1.10 the MiddlewareMixin is
no longer needed.