Document supported versions of Django; fix Travis to test these versions. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 0.30% (diff: 0.00%)@@ master #435 diff @@
========================================
Files 8 8
Lines 699 666 -33
Methods 0 0
Messages 0 0
Branches 114 110 -4
========================================
Hits 2 2
+ Misses 694 661 -33
Partials 3 3
|
| } | ||
|
|
||
| For more information, see `south documentation`__ | ||
| Since version 0.12.0 taggit uses Django migrations by default. |
There was a problem hiding this comment.
I think this could be removed since Django 1.6 is no longer supported.
|
LGTM, another thing I noticed is that you can use |
…ons. Remove workarounds for unsupported, unmaintained versions of Django. Per the 0.21 release notes, django-taggit only supports Django 1.7 and above. Updated docs to only refer to supported versions. Fixes #369
|
Thanks for the review! Made the recommended changes. |
|
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove workarounds for unsupported, unmaintained versions of Django.
Per the 0.21 release notes, django-taggit only supports Django 1.7 and
above.
Updated docs to only refer to supported versions.
I think you should also consider dropping support for Django 1.7. Is it no longer maintained or supported upstream, including for security issues. See https://www.djangoproject.com/download/#supported-versions. If you think it is a good idea, I can update the PR to remove all 1.7 workarounds as well.