Use session to store user validation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouke
added a commit
that referenced
this pull request
Sep 5, 2013
Use session to store user validation
|
Looks good, thanks for contributing! |
|
@mkruk45 What made you choose django-two-factor auth over the package django-otp, which is more feature-complete? |
|
I simply hadn't found that package. Also, after looking it over a bit, it doesn't seem to provide an easy way to switch an existing app over to a system which enables users to make two-factor verification necessary to authenticate at all. It appears that for django-otp, verification is completely separate from authentication, so that use-case isn't very easily supported. |
roffel
added a commit
to peperzaken/django-two-factor-auth
that referenced
this pull request
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the user param to the verify_computer view through a url param was a security hole.