Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still being maintained? #55

Closed
simhnna opened this issue Dec 24, 2017 · 15 comments
Closed

Is this project still being maintained? #55

simhnna opened this issue Dec 24, 2017 · 15 comments

Comments

@simhnna
Copy link
Contributor

simhnna commented Dec 24, 2017

I'm relying on this for a couple of small django apps because I didn't find any viable alternatives.

It appears as if the GitHub repository was moved sometime in the last year and since then nothing really happened.

I'd be willing to consider maintaining it, if @jazzband doesn't want to.

@kmike
Copy link
Collaborator

kmike commented Dec 28, 2017

I moved this repo here in hope of finding someone to maintain it, see https://jazzband.co/. Help is appreciated! There are some unfinished steps before actual developement and releasing can happen: https://github.com/jazzband/roadies/issues/70; I didn't have time to finish them, but they don't require me to be finished - help with these steps is appreciated as well.

@simhnna
Copy link
Contributor Author

simhnna commented Dec 28, 2017

Well it looks like no one from jazzband did anything during that time. As I said, I'm willing to help out, but from the activity in the last six months (or lack of) I'm not so sure if jazzband is the right place for django-widget-tweaks.

If no one from jazzband worked on it till now, I'm inclined to believe that fixing the issues in jazzband/roadies#70 won't change anything...

@kmike
Copy link
Collaborator

kmike commented Dec 28, 2017

If you're willing to help, you can join jazzband (anyone can join), and start commiting :) I'm fine with that, and curious how this would work. Jazzband is just a matter of organizing commit access rights - basically anyone can commit.

I've tried other ways as well:

and must admit they worked better so far. But technically it is not different - you can do everything in jazzband as you can do if you're a commiter in a separate organization, or an owner of a repository.

@simhnna
Copy link
Contributor Author

simhnna commented Dec 28, 2017

Jazzband is just a matter of organizing commit access rights - basically anyone can commit

That's what troubles me a little...

@simhnna
Copy link
Contributor Author

simhnna commented Dec 29, 2017

So, I joined the org, submitted a pr and merged it myself. I can even create/edit tags. Not sure if I can force-push or not.

I find the fact that I am able to do that, without any interaction with a human is a little troubling.

If you'd be willing to either create an org for it, or transfer it to me (I can of course give you access to it, if you want), I can continue to maintain it. It doesn't look like it needs that much. Otherwise I guess, I'll create a clean fork of it and publish it myself to pypi.

@simhnna simhnna mentioned this issue Dec 30, 2017
@simhnna
Copy link
Contributor Author

simhnna commented Jan 5, 2018

@kmike I just created another repo and would publish it on pypi if that's ok with you. Unless you'd prefer a transfer of some sort.

@simhnna
Copy link
Contributor Author

simhnna commented Jan 13, 2018

I just published it under the name django-widgets-improved

@iamjonmiller
Copy link

@simhnna Is your version working with 2.0? What name should I add to settings.py? Documentation for django-widgets-improved on pypi says "widget-tweaks", but it looks like everything is just pasted from docs here.

@simhnna
Copy link
Contributor Author

simhnna commented Feb 14, 2018

@iamjonmiller yes it is. It's a drop in replacement. You install it under the new name, but you don't have to change any settings or templates. The docs are almost the same but were updated to include what I'm writing in this comment :-)

@iamjonmiller
Copy link

iamjonmiller commented Feb 14, 2018

@simhnna Yeah just found that, for some reason it isn't working. I'm making sure everything on my end is right. So I should just have to pip uninstall django-widget tweaks, then pip install django-widgets-improved and all be well? Really appreciate the prompt response!

Because that's what I've done and it's spitting out this:
`"C:\Program Files\JetBrains\PyCharm 2017.3\bin\runnerw.exe" C:\Python36\python.exe C:/git/si-dash/manage.py runserver 0.0.0.0:80
Unhandled exception in thread started by <function check_errors..wrapper at 0x000001BD186BE378>
Traceback (most recent call last):
File "C:\Python36\lib\site-packages\django\utils\autoreload.py", line 225, in wrapper
fn(*args, **kwargs)
File "C:\Python36\lib\site-packages\django\core\management\commands\runserver.py", line 113, in inner_run
autoreload.raise_last_exception()
File "C:\Python36\lib\site-packages\django\utils\autoreload.py", line 248, in raise_last_exception
raise exception[1]
File "C:\Python36\lib\site-packages\django\core\management_init
.py", line 327, in execute
autoreload.check_errors(django.setup)()
File "C:\Python36\lib\site-packages\django\utils\autoreload.py", line 225, in wrapper
fn(*args, **kwargs)
File "C:\Python36\lib\site-packages\django_init_.py", line 24, in setup
apps.populate(settings.INSTALLED_APPS)
File "C:\Python36\lib\site-packages\django\apps\registry.py", line 89, in populate
app_config = AppConfig.create(entry)
File "C:\Python36\lib\site-packages\django\apps\config.py", line 90, in create
module = import_module(entry)
File "C:\Python36\lib\importlib_init_.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 978, in _gcd_import
File "", line 961, in _find_and_load
File "", line 948, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'widget_tweaks'

Edit: Looks like it is only installing the .dist-info
2018-02-14 10_06_54-site-packages

`

@simhnna
Copy link
Contributor Author

simhnna commented Feb 14, 2018

yes that should be enough. I don't have a windows system around right now, to try it out. I'm using linux. Can you try to use a clean virtualenv? if it works in a clean environment, something was probably not right with the old one. If it doesn't please open an issue about that in my repo. No need to clutter this issue. :-)

@iamjonmiller
Copy link

@simhnna Will do. Thanks!

@camilonova
Copy link
Member

@simhnna please consider working on this repo instead on a fork. This will make way more impact and help many others too.

Anyone at jazzband have access to do whatever you want, as a community we should take care of good changes on projects. A good way to start interacting is to make a PR and then ask someone else, at least one person, to review the changes and then merge them.

If you can't find someone to help review the PR you can merge it on your own too.

I'm willing to help if you want.

@simhnna
Copy link
Contributor Author

simhnna commented Mar 19, 2018

@camilonova my main issue with jazzband still remains, everybody in the whole world can just sign up and start doing stuff. I don't really like the idea of that being so easy.

@camilonova
Copy link
Member

@simhnna only "approved" users can publish changes to pypi. Please read https://jazzband.co/about/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants