Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline support for Feature objects in coord mapping utils #130

Merged
merged 2 commits into from
Jul 13, 2019

Conversation

rayrrr
Copy link
Member

@rayrrr rayrrr commented Jul 13, 2019

Following up on #128

  • change Feature object geometry in-place in mapping util
  • conform unit test to rest of test case
  • improve docstrings

See also #110

@auvipy
Copy link
Contributor

auvipy commented Jul 13, 2019

flake8 is failing

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #130 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   94.54%   94.78%   +0.24%     
==========================================
  Files          10       10              
  Lines         348      345       -3     
  Branches       70       69       -1     
==========================================
- Hits          329      327       -2     
  Misses         10       10              
+ Partials        9        8       -1
Impacted Files Coverage Δ
geojson/utils.py 86.66% <100%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 813117e...d049655. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #130 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   94.54%   94.78%   +0.24%     
==========================================
  Files          10       10              
  Lines         348      345       -3     
  Branches       70       69       -1     
==========================================
- Hits          329      327       -2     
  Misses         10       10              
+ Partials        9        8       -1
Impacted Files Coverage Δ
geojson/utils.py 86.66% <100%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 813117e...d049655. Read the comment docs.

@auvipy auvipy merged commit 7a1b814 into master Jul 13, 2019
@auvipy auvipy deleted the utils-feature-support branch July 13, 2019 16:12
@rayrrr
Copy link
Member Author

rayrrr commented Jul 13, 2019

Hi @auvipy, I am the new project lead of this repo. I wanted to include related docstring updates with this PR before merging it; I have a checklist in the PR description denoting that was work yet to be done. Going forward, please do not merge others' PRs in this repo without at least one of the original authors or a project lead saying it is ready to merge. Of course, we always welcome your direct contributions and code reviews. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants