Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include directive for Sphinx docs #134

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Add include directive for Sphinx docs #134

merged 1 commit into from
Sep 6, 2019

Conversation

rayrrr
Copy link
Member

@rayrrr rayrrr commented Sep 5, 2019

This PR uses a reST include directive in attempts of facilitating autogenerated ReadTheDocs docs while maintaining the rendered README on the GitHub repo homepage.

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          10       10           
  Lines         345      345           
  Branches       69       69           
=======================================
  Hits          329      329           
  Misses          9        9           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c492d11...954379e. Read the comment docs.

@auvipy auvipy merged commit d1a47d5 into master Sep 6, 2019
@auvipy auvipy deleted the read-the-docs-prep branch September 6, 2019 04:35
@rayrrr
Copy link
Member Author

rayrrr commented Sep 6, 2019

@auvipy I am the Project Lead of this repo. I already asked you nicely once before: please do not merge other peoples' open PRs in the geojson repo. Now, you have done it again. Now would be a good time to explain your penchant for doing this.

@auvipy
Copy link
Contributor

auvipy commented Sep 6, 2019

hi, sadly I didn't read the linked comment so I just merged this as it seems simple. anyway now I learn that you are the project lead, I will be more careful with a further merge of any PR.

@jezdez
Copy link
Member

jezdez commented Sep 6, 2019

@auvipy Quick note that I've replied to @rayrrr and you about this incident here: jazzband/help#132 (comment)

@rayrrr As a policy it may make sense for you to create draft PRs for those PRs that you want feedback first since they can't be merged without marking them ready for review first?

@rayrrr
Copy link
Member Author

rayrrr commented Sep 6, 2019

@auvipy thanks for the clarification, and I hope your behavior stays in line with your comment here going forward. @jezdez as for draft PRs, I guess we will have to give them a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants