Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding_width = 0 #80

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Fix padding_width = 0 #80

merged 1 commit into from
Nov 14, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 7, 2020

Based on kxxoling/PTable#2 from the PTable fork.

Thanks to @Sebelino for the original PR:

Fixes a bug where setting padding_width to 0 has the same effect as setting it to 1. This makes it possible to create compact tables like these:

+-+-+-+
|a|b|c|
|d|e|f|
|g|.|.|
+-+-+-+

abc
def
g..

Co-authored-by: Sebastian Olsson <sebelino7@gmail.com>
@hugovk hugovk added bug Something isn't working changelog: Fixed For any bug fixes labels Nov 7, 2020
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #80 (c0896b1) into master (f9913bb) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   87.31%   87.53%   +0.21%     
==========================================
  Files           3        3              
  Lines        1498     1516      +18     
==========================================
+ Hits         1308     1327      +19     
+ Misses        190      189       -1     
Flag Coverage Δ
GHA_Ubuntu 87.53% <100.00%> (+0.21%) ⬆️
GHA_Windows 87.53% <100.00%> (+0.21%) ⬆️
GHA_macOS 87.53% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/prettytable/prettytable.py 82.38% <100.00%> (+0.12%) ⬆️
tests/test_prettytable.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9913bb...c0896b1. Read the comment docs.

@hugovk hugovk merged commit 2b96eb5 into jazzband:master Nov 14, 2020
@hugovk hugovk deleted the fix-padding_width-0 branch November 14, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant