Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify difference with other forks #74

Closed
ericpre opened this issue Oct 18, 2020 · 3 comments
Closed

Clarify difference with other forks #74

ericpre opened this issue Oct 18, 2020 · 3 comments
Labels
question Further information is requested

Comments

@ericpre
Copy link

ericpre commented Oct 18, 2020

It seems that there are a couple of forks of prettytable:

From #23, it seems that ptable and prettytable are not compatible if installed in the same environment. However, do they still have the same API? Are they any features in ptable/ptable2 not available in prettytable?

Now that prettytable is back alive and has a maintenance/distribution infrastructure in place, it would be good to keep the development in this repository and try to merge with the forks (ptable/ptable2)?!

@hugovk hugovk added the question Further information is requested label Oct 18, 2020
@hugovk
Copy link
Member

hugovk commented Oct 28, 2020

It seems that there are a couple of forks of prettytable:

From #23, it seems that ptable and prettytable are not compatible if installed in the same environment. However, do they still have the same API?

The forks say they the API is compatible.

https://github.com/kxxoling/PTable says:

As PTable is a fork of PrettyTable, and compatible with all its APIs, so PTable is usage is the same as PrettyTable, and the installation would cover on the original PrettyTable.

Likewise, https://github.com/madebr/ptable2 says:

As ptable2 is a fork of PrettyTable, and compatible with all its APIs, so ptable2 is usage is the same as PrettyTable, and the installation would cover on the original PrettyTable.


Are they any features in ptable/ptable2 not available in prettytable?

Best addressed to the fork authors, or take a look at the commit/PR histories.


Now that prettytable is back alive and has a maintenance/distribution infrastructure in place, it would be good to keep the development in this repository and try to merge with the forks (ptable/ptable2)?!

Sounds like a good idea, PRs welcome! Fork authors (and others!) are welcome to join Jazzband and help with maintenance of this project.

In general, as this library is well used (1.3 million downloads/month!) we should be careful to maintain backwards compatibility, and only break things when necessary, and with a period of deprecation.

@hugovk
Copy link
Member

hugovk commented Nov 1, 2020

Looking at the merged PRs of PTable, here's a couple of candidates:

@hugovk
Copy link
Member

hugovk commented Nov 14, 2020

Looking at the merged PRs of PTable, here's a couple of candidates:

PRs merged for those!

@hugovk hugovk closed this as completed May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants