-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade unit tests #520
Upgrade unit tests #520
Conversation
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
=======================================
Coverage 90.84% 90.84%
=======================================
Files 28 28
Lines 2664 2664
=======================================
Hits 2420 2420
Misses 244 244
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The "pre-commit.ci - pr" check failed because the pre-commit is checking against master instead of a tag here: https://github.com/jazzband/tablib/pull/520/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9R14 We need to use Let's just remove the pre-commit check for now, and can add it back when there's a release. |
5c779b8
to
d86456a
Compare
I've released 0.4.2 with the changes in the pre-commit hook: https://github.com/isidentical/teyit/releases/tag/0.4.2 |
d86456a
to
a73a261
Compare
Thanks for the new release! "pre-commit.ci - pr" now errors because it seems it's running on Python 3.8. I've opened an issue to ask how we can set a Python version at pre-commit.ci: pre-commit-ci/issues#117 |
pre-commit.ci now defaults to Python 3.10 and passes: |
I used https://github.com/isidentical/teyit to upgrade the unit tests to use methods which give more useful error messages upon failure.