Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed errors on settings page #52

Merged
merged 3 commits into from
Apr 11, 2017
Merged

Fixed errors on settings page #52

merged 3 commits into from
Apr 11, 2017

Conversation

ashleyfae
Copy link
Contributor

I fixed an undefined index error in the "Book cover size" field. You were referencing an array key that didn't exist in the defaults: $selected = $options['thumbnail'];. I'm not sure what you actually wanted to be the default there so I went with 'thumbnail'.

Then I fixed a few small other things:

  1. You were doing like a double echo on the selected() functions, which resulted in some extra selected="selected" markup. I just set the third parameter to false in all instances of selected().
  2. I escaped all the values.

Copy link
Owner

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@jazzsequence jazzsequence merged commit 06ddad2 into jazzsequence:master Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants