Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the interface of PersistentTabView #42

Merged
merged 149 commits into from
Mar 13, 2024
Merged

Rework the interface of PersistentTabView #42

merged 149 commits into from
Mar 13, 2024

Conversation

jb3rndt
Copy link
Owner

@jb3rndt jb3rndt commented Jun 22, 2022

This should make the PersistentTabView more understandable and robust, expecially when using a custom navbar.

ToDo:

  • Remove PersistentTabViewBase which was just wrapped by PersistentTabView
  • Make the navbar a builder
  • Move itemAnimationProperties out of PersistentTabView and pass it to the NavBar directly
  • Move navBarDecoration out of PersistentTabView and pass it to the NavBar directly
  • backgroundColor changes navbar color -> move into navBarDecoration
  • Move neumorphicProperties out of PersistentTabView and pass it to the NavBar directly
  • Rework PersistentBottomNavBarItem to directly set the correct values for the colors
  • Unify primary color and secondary color scheme
  • Migration guide

@jb3rndt jb3rndt merged commit 91c2517 into master Mar 13, 2024
7 checks passed
@jb3rndt jb3rndt deleted the rework_interface branch March 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants