fixed style3 inactive color #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb3rndt
reviewed
Sep 9, 2022
There was a problem hiding this comment.
This will probably be a problem in other styles too but it will be reworked in #42 anyway... The only thing is that we should conform to the documentation which uses the secondary color for the text and defaults to the primary color:
Co-authored-by: Jannis Berndt <berndtjannis@gmail.com>
Co-authored-by: Jannis Berndt <berndtjannis@gmail.com>
|
Oops, good catch on the edits. I didn't see the other PR. Should I check out the other styles too or not worry about it since it's getting updating in #42? |
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 73.86% 73.81% -0.06%
==========================================
Files 36 36
Lines 3069 3074 +5
==========================================
+ Hits 2267 2269 +2
- Misses 802 805 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I will fix them in #42, thanks for contributing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
style 3 was not correctly applying inactive color