-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Init command not using template properties's default value #1232
feat: Init command not using template properties's default value #1232
Conversation
- Removing getter and setter pairs from TemplateProperty and using public modifier - Applying template property defaults in init command by default, option to disable. - Documentation for the new option
Codecov Report
@@ Coverage Diff @@
## main #1232 +/- ##
============================================
+ Coverage 58.26% 58.39% +0.12%
- Complexity 1060 1065 +5
============================================
Files 86 86
Lines 5756 5761 +5
Branches 976 978 +2
============================================
+ Hits 3354 3364 +10
+ Misses 1906 1901 -5
Partials 496 496
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Personally I don't see much use for an option that doesn't apply default values. Do you @maxandersen ? |
Yeah. Same. No need to be able to turn this off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed update that removes the flag. if pass ci good to go.
Sorry for not responding for the change requests, I'm on "holiday", thank you for the changes and merge. |
Solves this: #1231