feat: Init command not using template properties's default value #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removing getter and setter pairs from TemplateProperty and using public modifier - Applying template property defaults in init command by default, option to disable. - Documentation for the new option
Codecov Report
@@ Coverage Diff @@
## main #1232 +/- ##
============================================
+ Coverage 58.26% 58.39% +0.12%
- Complexity 1060 1065 +5
============================================
Files 86 86
Lines 5756 5761 +5
Branches 976 978 +2
============================================
+ Hits 3354 3364 +10
+ Misses 1906 1901 -5
Partials 496 496
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Personally I don't see much use for an option that doesn't apply default values. Do you @maxandersen ? |
|
Yeah. Same. No need to be able to turn this off. |
maxandersen
reviewed
Feb 10, 2022
maxandersen
reviewed
Feb 10, 2022
maxandersen
reviewed
Feb 10, 2022
maxandersen
previously approved these changes
Feb 11, 2022
quintesse
reviewed
Feb 11, 2022
|
Sorry for not responding for the change requests, I'm on "holiday", thank you for the changes and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves this: #1231