Fix default values via reflection for LoggerInterface (PHP 8 only) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE See #78
ihor-sviziev
reviewed
Nov 5, 2020
| bool(true) | ||
| array(0) { | ||
| } | ||
| --XFAIL-- |
There was a problem hiding this comment.
Maybe it's better to use EXPECTF here, similar to php/php-src@3709e74#diff-2897306bc3a270854edfb5721b5506db844ec9360883a2c07b23efcb021a7db5R24-R25 ?
There was a problem hiding this comment.
This test is meant as documentation that the behaviour for the extension under PHP 7 isn't perfectly correct, so I think XFAIL is appropriate in this case.
ihor-sviziev
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE
See #78