Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBDS-3408 JBIDE-17546 variable not picked up ... ...automatically, so need to set up mojo override #316

Closed
wants to merge 1 commit into from
Closed

Conversation

nickboldt
Copy link
Member

No description provided.

@mickaelistria
Copy link
Contributor

Since the execution is inherited, you can skip the execution block on this pom, and only define the configuration part on the mojo

<plugin>
  <groupId>org.jboss.tools.tycho-plugins</groupId>
  <artifactId>repository-utils</artifactId>
  <configuration>
    <p2StatsUrl>${p2statsUr}</p2StatsUrl>
  </configuration>
</plugin>

Or simply introduce and use the p2StatsUrl property in parent pom, and just override it in devstudio poms.

@nickboldt
Copy link
Member Author

"Or simply introduce and use the p2StatsUrl property in parent pom, and just override it in devstudio poms."

Tried that: it didn't work: 0e33a36

@nickboldt
Copy link
Member Author

BTW, related: JBDS-3423

@mickaelistria
Copy link
Contributor

It didn't work because the parent pom doesn't consume such property. I suggest we also update the parent pom to consume 0e33a36 without having to change the product pom.xml more: jbosstools/jbosstools-build#190

@nickboldt
Copy link
Member Author

Good idea, but there's a typo in that PR and you need a fallback value for when JOB_NAME is undefined.

@mickaelistria
Copy link
Contributor

Replaced by jbosstools/jbosstools-build#190

@nickboldt nickboldt deleted the JBDS-3408_JBIDE-17546_again branch October 14, 2015 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants