Fixed compiler warning -Wdeprecated with clang. #452

Merged
merged 2 commits into from Jan 5, 2017

Projects

None yet

2 participants

@jbreitbart
Contributor

Starting with C++11 implicit copy-constructors are deprecated when the class
has a user defined destructor.

@jbreitbart jbreitbart Fixed compiler warning -Wdeprecated with clang.
Starting with C++11 implicit copy-constructors are deprecated when the class
has a user defined destructor.
b5af43e
@jbeder

LGTM, pending one nit about the documentation change.

include/yaml-cpp/parser.h
@@ -47,7 +47,7 @@ class YAML_CPP_API Parser : private noncopyable {
void Load(std::istream& in);
/**
- * Handles the next document by calling events on the {@param eventHandler}.
+ * Handles the next document by calling events on the { @param eventHandler }.
@jbeder
jbeder Jan 2, 2017 Owner

Since this seems to be an incorrect way to refer to a parameter (I can't seem to find any indication it's even allowed to refer to a @param inline like this), can you just change it to @code? I don't want to special-case this one for having a space at the end.

@jbreitbart jbreitbart Fixes -Wdocumentation warning.
yaml-cpp/parser.h:50:65: warning: parameter 'eventHandler}.' not found in the function
      declaration [-Wdocumentation]
   * Handles the next document by calling events on the {@param eventHandler}.
                                                                ^~~~~~~~~~~~~~
yaml-cpp/parser.h:50:65: note: did you mean 'eventHandler'?
   * Handles the next document by calling events on the {@param eventHandler}.
                                                                ^~~~~~~~~~~~~~
                                                                eventHandler
9558337
@jbreitbart
Contributor

Fixed. Sorry, I must have overlooked the comment style in the rest of the file.

@jbeder jbeder merged commit 86c69bb into jbeder:master Jan 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment