Fixed compiler warning -Wdeprecated with clang. #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with C++11 implicit copy-constructors are deprecated when the class has a user defined destructor.
jbeder
requested changes
Jan 2, 2017
| @@ -47,7 +47,7 @@ class YAML_CPP_API Parser : private noncopyable { | |||
| void Load(std::istream& in); | |||
|
|
|||
| /** | |||
| * Handles the next document by calling events on the {@param eventHandler}. | |||
| * Handles the next document by calling events on the { @param eventHandler }. | |||
There was a problem hiding this comment.
yaml-cpp/parser.h:50:65: warning: parameter 'eventHandler}.' not found in the function
declaration [-Wdocumentation]
* Handles the next document by calling events on the {@param eventHandler}.
^~~~~~~~~~~~~~
yaml-cpp/parser.h:50:65: note: did you mean 'eventHandler'?
* Handles the next document by calling events on the {@param eventHandler}.
^~~~~~~~~~~~~~
eventHandler
jbreitbart
force-pushed
the
explicit_copy_constructor
branch
from
dfd35c0
to
9558337
Compare
|
Fixed. Sorry, I must have overlooked the comment style in the rest of the file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with C++11 implicit copy-constructors are deprecated when the class
has a user defined destructor.